Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tab completions work in zsh #19

Merged
merged 1 commit into from
Nov 4, 2015
Merged

Make tab completions work in zsh #19

merged 1 commit into from
Nov 4, 2015

Conversation

nhandler
Copy link
Contributor

@nhandler nhandler commented Nov 4, 2015

This solution is based on a Pull Request by [croach])(https://github.com/croach) for the nvm project. I tested it with make itest_lucid and make itest_trusty. It using the same completions that bash uses, so they should always be in sync.

@nhandler nhandler self-assigned this Nov 4, 2015
@@ -13,6 +13,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

if [[ -n ${ZSH_VERSION-} ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does zsh parse /etc/profile.d/*.sh? Not *.zsh? I have no idea

@solarkennedy
Copy link
Contributor

If it has a test, it probably works! Ship!

nhandler added a commit that referenced this pull request Nov 4, 2015
Make tab completions work in zsh
@nhandler nhandler merged commit a618192 into master Nov 4, 2015
@nhandler nhandler deleted the zsh-completions branch November 4, 2015 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants